Skip to content

T9245: podman: add libsystemd-dev to enable automatic health checks - #1278

Open
opswill wants to merge 1 commit into
vyos:rollingfrom
opswill:patch-1
Open

T9245: podman: add libsystemd-dev to enable automatic health checks#1278
opswill wants to merge 1 commit into
vyos:rollingfrom
opswill:patch-1

Conversation

@opswill

@opswill opswill commented Aug 28, 2026

Copy link
Copy Markdown

Change summary

Add libsystemd-dev to the Podman build dependencies so the systemd build tag is enabled.

Without it, Podman health checks can be configured and run manually, but are not scheduled automatically.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T9245

Related PR(s)

How to test / Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@coderabbitai

coderabbitai Bot commented Aug 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 878b30b1-9ac0-410a-b377-19ec11d7d3c1

📥 Commits

Reviewing files that changed from the base of the PR and between 14d959f and fb99f21.

📒 Files selected for processing (1)
  • scripts/package-build/podman/package.toml
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • ansible/ansible (manual)

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (2)
  • GitHub Check: Mergify Merge Protections
  • GitHub Check: Summary
⚠️ CI failures not shown inline (1)

GitHub Check: Mergify Merge Protections: 1 applicable rule, 0 validating requirements

Conclusion: failure

View job details

# Merge Protections
🔴 **1 of 1 protections blocking** · waiting on 🙋 you
| | Protection | Waiting on |
|:--:|:--|:--:|
| 🔴 | **invalid-task-id label must be absent to merge** | 🙋 you |
## 🔴 invalid-task-id label must be absent to merge
**Waiting for**
- [ ] `label != invalid-task-id`
<details><summary>This rule is failing.</summary>
Block merge while the invalid-task-id label is present. Set by the per-repo product T-ID rule (product repos only); dormant where the label is never applied.
- [ ] `label != invalid-task-id`
</details>
🧰 Additional context used
🔍 Remote MCP vyos.dev

Relevant review context

  • T9245 reports Podman 5.8.4 on VyOS 2026.08.22-0013 leaving health checks in starting; manual checks succeed, but no Podman health-check timers are created.
  • The reported cause is that Podman was built without its systemd build tag. Adding libsystemd-dev is proposed to allow hack/systemd_tag.sh to enable it.
  • Journald support in conmon does not prove Podman itself has systemd support, since conmon may be linked to libsystemd independently.
  • The task references an upstream Podman PR addressing health checks for non-systemd builds, confirming the observed behavior is related to scheduler support.
  • T9245 remains open and is currently in the “Need Triage” column.
🔇 Additional comments (1)
scripts/package-build/podman/package.toml (1)

197-198: LGTM!

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated Podman package build requirements to include the systemd development library.

Walkthrough

The Podman package build now declares libsystemd-dev as a build dependency.

Changes

Podman package build

Layer / File(s) Summary
Build dependency declaration
scripts/package-build/podman/package.toml:197-198		 Adds libsystemd-dev to the Podman package build dependencies.

Merge Risk: ⚪ Minimal · up to fb99f

This localized dependency change enables automatic Podman health-check scheduling; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the Podman build dependency change and its purpose of enabling automatic health checks.
Description check ✅ Passed The description accurately explains the dependency change, its effect on Podman health checks, and its relation to task T9245.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
✨ Simplify code
  • Create PR with simplified code

Warning

Your free Security trial is over. An organization admin can activate Security or dismiss this notice.

Comment @coderabbitai help to get the list of available commands.

@mergify mergify Bot removed the invalid-task-id label Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@opswill opswill

Labels

rolling

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@opswill